linux-kernel - Re: [patch] natsemi: fix oops, link back netdevice from private-struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35146.86.7.220.119.1193247446.squirrel@wmbeta.mxes.net>
Date:	Wed, 24 Oct 2007 18:37:26 +0100 (BST)
From:	"Andrew" <andrew@...less.net>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [patch] natsemi: fix oops,
      link back netdevice from private-struct

On Wed, October 24, 2007 12:58, Ingo Molnar wrote:
>
> the NULL dereference is here:
>
> (gdb) list *0xffffffff804a9504
> 0xffffffff804a9504 is in natsemi_poll (drivers/net/natsemi.c:717).
> 712             return count;
> 713     }
> 714
> 715     static inline void __iomem *ns_ioaddr(struct net_device *dev)
> 716     {
> 717             return (void __iomem *) dev->base_addr;
> 718     }
> 719
>
>
> which is this code from natsemi.c:
>
> 2227            struct net_device *dev = np->dev;
> 2228            void __iomem * ioaddr = ns_ioaddr(dev);
> 2229            int work_done = 0;
>
>
> seems like the NAPI changes in -rc1 added an np->dev field but forgot to initialize it ...
>
> does the patch below fix the oops for you?
>
> Ingo
>
>

Yep, that got it, thanks.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/