linux-kernel - Re: [2.6 patch] unexport icmpmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071024191437.GF30533@stusta.de>
Date:	Wed, 24 Oct 2007 21:14:37 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	David Stevens <dlstevens@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [2.6 patch] unexport icmpmsg_statistics

On Wed, Oct 24, 2007 at 12:07:45PM -0700, David Stevens wrote:
> netdev-owner@...r.kernel.org wrote on 10/24/2007 09:24:10 AM:
> 
> > This patch removes the unused EXPORT_SYMBOL(icmpmsg_statistics).
> > 
> > Signed-off-by: Adrian Bunk <bunk@...nel.org>
> > 
> > ---
> > 4ce74657ac0b1bdcb4c7bc359d05643f8cc4a08b 
> > diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
> > index 272c69e..233de06 100644
> > --- a/net/ipv4/icmp.c
> > +++ b/net/ipv4/icmp.c
> > @@ -1104,5 +1104,4 @@ void __init icmp_init(struct net_proto_family 
> *ops)
> >  EXPORT_SYMBOL(icmp_err_convert);
> >  EXPORT_SYMBOL(icmp_send);
> >  EXPORT_SYMBOL(icmp_statistics);
> > -EXPORT_SYMBOL(icmpmsg_statistics);
> >  EXPORT_SYMBOL(xrlim_allow);
> 
>         "icmpmsg_statistics" belongs with (and replaces some of the 
> old...)
> "icmp_statistics". I'm not sure that any modules use it, but I think you
> should remove both or neither.

icmp_statistics is used by the dccp_ipv4 and sctp modules.

icmpmsg_statistics is not used by any modules.

>                                                                 +-DLS

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/