linux-kernel - Re: [patch] portman2x4.c: fix boot hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Oct 2007 22:12:32 +0200
From:	Frans Pop <elendil@...net.nl>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org, perex@...e.cz, tiwai@...e.de,
	torvalds@...ux-foundation.org
Subject: Re: [patch] portman2x4.c: fix boot hang

Ingo Molnar wrote:
>  if ((parport_read_status(p) & ESTB) == ESTB)
> -		return 1;	/* CODE 1 - Strobe Failure. */
> +		return -EIO;	/* CODE 1 - Strobe Failure. */
>  
>  /* Set for RXDATA0 where no damage will be done. */
>  /* 5 */
> @@ -475,7 +475,7 @@ static int portman_probe(struct parport
>  
>  /* 6 */
>  if ((parport_read_status(p) & ESTB) != ESTB)
> -		return 1;	/* CODE 1 - Strobe Failure. */
> +		return -EIO;	/* CODE 1 - Strobe Failure. */

Why are you keeping the "CODE 1" comment? Just "Strobe Failure" as comment 
would seem more consistent with the change.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/