| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Oct 2007 15:34:41 -0600 From: Matthew Wilcox <matthew@....cx> To: Joe Perches <joe@...ches.com> Cc: Linus Torvalds <torvalds@...l.org>, Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org Subject: Re: Stringbuf, v2 On Wed, Oct 24, 2007 at 02:06:33PM -0700, Joe Perches wrote: > On Wed, 2007-10-24 at 14:57 -0600, Matthew Wilcox wrote: > > If you look at the patches, you'll see that they basically all have a > > wrapper around sb_printf that I was able to insert the GFP argument > > into, so I don't see this as a win. > > I was hoping that each module/subsystem would not need a > separate wrapper and could use the plain sb_printf function. Then they should carefully think about whether they need GFP_ATOMIC or GFP_KERNEL. Just like we don't have a kalloc() that uses GFP_ATOMIC to spare people from having to think about it. ISDN and sound had done that thinking for me -- one knew they needed GFP_ATOMIC, the other needed GFP_KERNEL. I was able to work out that GFP_KERNEL made sense for the partition code. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists