linux-kernel - Re: mmc_spi stopped working

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200710241537.10566.david-b@pacbell.net>
Date:	Wed, 24 Oct 2007 15:37:10 -0700
From:	David Brownell <david-b@...bell.net>
To:	Pierre Ossman <drzeus-list@...eus.cx>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: mmc_spi stopped working

On Monday 22 October 2007, Pierre Ossman wrote:
> On Wed, 17 Oct 2007 12:37:13 -0700
> David Brownell <david-b@...bell.net> wrote:
> 
> > When enumerating MMC cards using SPI, don't support the "just probe"
> > mechanism since it doesn't always work.  Instead, always wait for the
> > reset to complete before issuing the next request.
> > 
> > This is a regression ... this SanDisk MMC card used to enumerate with
> > no trouble, despite this particular spec violation.
> > 
> 
> I've been testing a bit more here, and I can't get this particular bug.

It's not just a bug, it's a regression ... a new bug which
was introduced by some patch.  ;)


> I have others though: 
> 
> Out of my five MMC cards, only two work properly. One doesn't respond
> to SPI commands at all, and two hang on a second CMD0 and return
> ILLEGAL_COMMAND on a second run of CMD1. All of this is of course wildly
> out of spec. SPI seems to be a bonus, not a given. :/   

SPI works fine on all the MMC and SD cards I've got here,
other than the minor glitch fixed by the "don't just probe"
patch I sent.

As you know, to be spec-conformant they *must* support SPI.
Agreed, there are too many vendors who don't appear to value
following specs.  If those cards which are using the MMC or
SD trade marks, you might notify the relevant consortium and
asking them to fix those vendors.  ;)


> As for your card, could you send me a dump as I'm unable to produce
> the issue here? 

I'm not sure what you mean by "dump", but appended the sysfs attributes
produced after I disabled that new "just probe" mechanism.

- Dave



This is a dump of the /sys/class/mmc_host/mmc0/mmc0:0001 file attributes
(except the card serial number) for a SanDisk MMC card which doesn't like
SPI requests (like reading OCR) before the reset finishes.

This card _used_ to enumerate with the MMC-over-SPI stack, but
a recent change in the MMC core now prevents it from doing that...

=== cid
00000000  30 30 30 30 30 32 35 33  34 34 34 64 34 32 32 64  |00000253444d422d|
00000010  33 31 33 36 33 32 61 39  31 66 31 30 38 34 33 31  |313632a91f108431|
00000020  0a                                                |.|
00000021

=== csd
00000000  34 34 32 36 30 30 32 61  31 66 66 39 38 33 64 33  |4426002a1ff983d3|
00000010  65 34 62 34 38 33 66 66  31 32 34 30 34 30 38 31  |e4b483ff12404081|
00000020  0a                                                |.|
00000021

=== date
00000000  30 38 2f 32 30 30 31 0a                           |08/2001.|
00000008

=== fwrev
00000000  30 78 32 0a                                       |0x2.|
00000004

=== hwrev
00000000  30 78 33 0a                                       |0x3.|
00000004

=== manfid
00000000  30 78 30 30 30 30 30 32  0a                       |0x000002.|
00000009

=== name
00000000  53 44 4d 42 2d 31 36 0a                           |SDMB-16.|
00000008

=== oemid
00000000  30 78 30 30 30 30 0a                              |0x0000.|
00000007

=== type
00000000  4d 4d 43 0a                                       |MMC.|
00000004

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/