linux-kernel - Re: [PATCH 2.6.24-rc1] fix sg_phys to use dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071025085239.GH5053@kernel.dk>
Date:	Thu, 25 Oct 2007 10:52:39 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Rolf Eike Beer <eike-kernel@...tec.de>
Cc:	Arjan van de Ven <arjan@...radead.org>,
	Hugh Dickins <hugh@...itas.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.24-rc1] fix sg_phys to use dma_addr_t

On Thu, Oct 25 2007, Rolf Eike Beer wrote:
> Am Donnerstag, 25. Oktober 2007 schrieb Arjan van de Ven:
> > > Signed-off-by: Hugh Dickins <hugh@...itas.com>
> > > ---
> > > Whether this is a complete patch, suitable for all architectures,
> > > I'm not sure: it builds, boots and runs correctly on the x86_32 box
> > > in question, but you'll be a lot wiser than me about using dma_addr_t
> > > for everyone.  (Seems a bit of a shame to include <asm/types.h> here,
> > > when I think all arches already get to include it one way or another,
> > > typically via asm/scatterlist.h; but I guess it's safest to repeat
> > > it.)
> >
> > there is a problem with this... sg_phys doesn't return an actual *dma*
> > address.... at least not an address you can give to the device.
> > Using dma_addr_t is thus a bit misleading.....
> 
> Ok, then: how do I actually get such an address?

You use the dma mapping api, Documentation/DMA-mapping.txt

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/