[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071025130934.7b38d363@hyperion.delvare>
Date: Thu, 25 Oct 2007 13:09:34 +0200
From: Jean Delvare <khali@...ux-fr.org>
To: Riku Voipio <riku.voipio@....fi>
Cc: "Mark M. Hoffman" <mhoffman@...htlink.com>,
Adrian Bunk <bunk@...nel.org>, linux-kernel@...r.kernel.org,
lm-sensors@...sensors.org
Subject: Re: [lm-sensors] hwmon/f75375s.c: buggy if()
Hi Riku,
On Wed, 24 Oct 2007 14:50:34 +0300, Riku Voipio wrote:
> On Fri, Oct 19, 2007 at 02:37:54PM +0200, Jean Delvare wrote:
> > Take a look at the w83781d
> > driver for an example.
>
> Btw, I think your example code has a indentation bug:
>
> if (kind != w83781d)
> err = sysfs_chmod_file(&dev->kobj,
> &sensor_dev_attr_temp3_alarm.dev_attr.attr,
> S_IRUGO | S_IWUSR);
> if (err)
> return err;
Indentation is correct, but curly braces are missing! Nice catch,
thanks for reporting. It happens to be harmless in this specific case,
but it still needs fixing. I'll submit a patch shortly.
--
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists