linux-kernel - Re: [patch 2.6.24-rc1] resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071025132939.3fd010f9@the-village.bc.nu>
Date:	Thu, 25 Oct 2007 13:29:39 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	David Brownell <david-b@...bell.net>
Cc:	Jeff Garzik <jeff@...zik.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg KH <greg@...ah.com>
Subject: Re: [patch 2.6.24-rc1] resource_len() utility function

> So you'd suggest having search utilities (as with platform_bus)
> returning resource indices not resources?

That seems a bad idea to me

> Thing is, BARs are usually well defined, but when folk glue
> resources together they use whatever order is convenient on
> that particular platform.  And different platforms can have
> different numbers and types of resources, etc.

Far better I think that pci_ functions that take BAR values end up as
wrappers of the form

	pci_iomap(pdev, bar)
		return dev_iomap_resource(&pdev->resource[bar]);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/