linux-kernel - [PATCH]fs: Fix to correct the mbcache entries counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <728201270710250803p72c656d1nca58ad0bf4f91d41@mail.gmail.com>
Date:	Thu, 25 Oct 2007 10:03:28 -0500
From:	"Ram Gupta" <ram.gupta5@...il.com>
To:	"Andrew Morton" <akpm@...l.org>
Cc:	"linux mailing-list" <linux-kernel@...r.kernel.org>,
	torvalds@...ux-foundation.org
Subject: [PATCH]fs: Fix to correct the mbcache entries counter

This patch fixes the c_entry_count counter of the mbcache. Currently
it increments the counter first & allocate the cache entry later. In
case of failure to allocate the entry due to insufficient memory this
counter is still left incremented. This patch fixes this anomaly.

Signed-off-by: Ram Gupta <ram.gupta5@...il.com>
---------------
--- linux-2.6.23.1/fs/mbcache.c.orig    2007-10-25 09:19:28.000000000 -0500
+++ linux-2.6.23.1/fs/mbcache.c 2007-10-25 09:19:59.000000000 -0500
@@ -403,9 +403,9 @@ mb_cache_entry_alloc(struct mb_cache *ca
 {
        struct mb_cache_entry *ce;

-       atomic_inc(&cache->c_entry_count);
        ce = kmem_cache_alloc(cache->c_entry_cache, GFP_KERNEL);
        if (ce) {
+               atomic_inc(&cache->c_entry_count);
                INIT_LIST_HEAD(&ce->e_lru_list);
                INIT_LIST_HEAD(&ce->e_block_list);
                ce->e_cache = cache;

Thanks
Ram Gupta
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/