linux-kernel - Re: [2.6 patch] blackfin: "extern inline" -> "static inline"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071025165344.GL30533@stusta.de>
Date:	Thu, 25 Oct 2007 18:53:44 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	Mike Frysinger <vapier.adi@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Jie Zhang <jzhang.linux@...il.com>, bryan.wu@...log.com,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] blackfin: "extern inline" -> "static inline"

On Thu, Oct 25, 2007 at 12:16:40PM -0400, Mike Frysinger wrote:
> On 10/25/07, Adrian Bunk <bunk@...nel.org> wrote:
> > On Wed, Oct 24, 2007 at 08:06:14PM -0700, H. Peter Anvin wrote:
> > > Mike Frysinger wrote:
> > >> we'll have to either use the gcc attributes to force old inline
> > >> behavior or use the gcc flag to force it
> > >
> > > We should probably have an extern_inline define then, assuming this is a
> > > function that does exist in a linkable version already -- otherwise "static
> > > inline" is correct.
> >
> > Since we #define inline to be __attribute__((always_inline))
> > "extern inline" with the old semantics would only behave differently
> > if someone took the address of one of these string functions.
> 
> that isnt what we intended ;)
> 
> > Does this happen anywhere in the blackfin port?
> 
> gcc is also free to ignore the optimized inline in favor of an
> external reference

It is not since we #define inline to be __attribute__((always_inline)).

> -mike

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/