linux-kernel - Re: [PATCH] Wipe out traditional opt from x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4720D0F5.4040407@zytor.com>
Date:	Thu, 25 Oct 2007 10:23:01 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Glauber de Oliveira Costa <gcosta@...hat.com>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Jeremy Fitzhardinge <jeremy@...p.org>, glommer@...il.com
Subject: Re: [PATCH] Wipe out traditional opt from x86_64 Makefile

Glauber de Oliveira Costa wrote:
> Among other things, using -traditional as a gcc option stops us from
> using macro token pasting, which is a feature we heavily rely on.
> 
> There was still a use of -traditional in arch/x86/kernel/Makefile_64,
> which this patch removes.
> 
> I don't see any problems building kernels in my x86_64 box without
> -traditional.
> 
> Signed-off-by: Glauber de Oliveira Costa <gcosta@...hat.com>
> ---
>  arch/x86/kernel/Makefile_64 |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/Makefile_64 b/arch/x86/kernel/Makefile_64
> index 82da906..03a01f6 100644
> --- a/arch/x86/kernel/Makefile_64
> +++ b/arch/x86/kernel/Makefile_64
> @@ -3,7 +3,6 @@
>  #
>  
>  extra-y 	:= head_64.o head64.o init_task.o vmlinux.lds
> -#EXTRA_AFLAGS	:= -traditional
>  obj-y	:= process_64.o signal_64.o entry_64.o traps_64.o irq_64.o \
>  		ptrace_64.o time_64.o ioport_64.o ldt_64.o setup_64.o i8259_64.o sys_x86_64.o \
>  		x8664_ksyms_64.o i387_64.o syscall_64.o vsyscall_64.o \

At least *at one point*, ld scripts were whitespace-sensitive in a way 
that called for using -traditional.  Doesn't mean that anything else 
needs it, though.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/