linux-kernel - Re: [patch 2.6.24-rc1] resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200710241947.15129.david-b@pacbell.net>
Date:	Wed, 24 Oct 2007 19:47:14 -0700
From:	David Brownell <david-b@...bell.net>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg KH <greg@...ah.com>
Subject: Re: [patch 2.6.24-rc1] resource_len() utility function

On Wednesday 24 October 2007, Jeff Garzik wrote:
> With regards to resource reservation...  IMO we should mimic struct 
> pci_dev and add struct resource[] to struct device.

One minor difficulty:  PCI has a limit on the number of BARs,
but other busses don't.  It'd be better as a "struct resource *".


> Just like we have pci_request_regions(), we should also be able to 
> easily to a dev_request_regions().  the implementation should be very 
> close to pci_request_region() and pci_release_region().

Wouldn't it be nicer to have PCI use those dev_*() calls?
Ideally pci_request_region() wraps dev_request_region()...


> Then a dev_iomap() analogue to pci_iomap() should be pretty 
> straightforward to create.

Another minor nit:  addressing the various resource types.
The platform bus code has multiple lookup schemes. 

Calls like resource_iomap() might be more flexible, so that
lookup schemes can stay flexible.

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/