linux-kernel - Re: [PATCH 3/4] [x86] : Add support for the RDC R-321x SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071025142611.a1bb9088.akpm@linux-foundation.org>
Date:	Thu, 25 Oct 2007 14:26:11 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Florian Fainelli <florian.fainelli@...ecomint.eu>
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com
Subject: Re: [PATCH 3/4] [x86] : Add support for the RDC R-321x SoC

On Tue, 16 Oct 2007 13:41:31 +0200
Florian Fainelli <florian.fainelli@...ecomint.eu> wrote:

> +static struct {
> +	struct completion stop;
> +	volatile int running;
> +	struct timer_list timer;
> +	volatile int queue;
> +	int default_ticks;
> +	unsigned long inuse;
> +} rdc321x_wdt_device;

Why the volatiles?  If these actually help then it's probably an indication
that something is wrong in the implementation.

Documentation/volatile-considered-harmful.txt has some details.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/