linux-kernel - Re: [PATCH] ata: ahci: Enable enclosure management via LED (resend)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071025145047.1c5e96f3.kristen.c.accardi@intel.com>
Date:	Thu, 25 Oct 2007 14:50:47 -0700
From:	Kristen Carlson Accardi <kristen.c.accardi@...el.com>
To:	Ingo Oeser <ioe-lkml@...eria.de>
Cc:	akpm@...ux-foundation.org, jeff@...zik.org,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	Richard Purdie <rpurdie@...nedhand.com>
Subject: Re: [PATCH] ata: ahci: Enable enclosure management via LED (resend)

On Thu, 25 Oct 2007 23:35:11 +0200
Ingo Oeser <ioe-lkml@...eria.de> wrote:

> Hi Kristen,
> 
> On Thursday 25 October 2007, Kristen Carlson Accardi wrote:
> > Enable enclosure management via LED
> > 
> > As described in the AHCI spec, some AHCI controllers may support 
> > Enclosure management via a variety of protocols.  This patch
> > adds support for the LED message type that is specified in 
> > AHCI 1.1 and higher.
> 
> Linux has a LED subsystem for that. May I suggest, that you just register
> these leds and let userspace handle them via that via the LED API?
> 
> The LED userspace API is described in Documentation/leds-class.txt
> and the headers for registering LEDs is linux/leds.h under include/
> 
> Since you explicitly WANT user space to control these, that should
> be the right API. 
> 
> Richard, what do YOU think?
> 
> 
> Best Regards
> 
> Ingo Oeser
> 

I did look into using the LED class for this, but it didn't appropriate
as I wanted the leds to be associated with a particular disk, and not
with the platform as a whole.  It seemed to me that the led_class was 
a bit of overkill for what we needed to do here, since we just need 
on/off and nothing else.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/