linux-kernel - Re: [PATCH] Fix /proc/acpi/alarm BCD alarm encodings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071025151334.f8879fe5.akpm@linux-foundation.org>
Date:	Thu, 25 Oct 2007 15:13:34 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	lkml@....ca, linux-kernel@...r.kernel.org,
	Len Brown <lenb@...nel.org>
Subject: Re: [PATCH] Fix /proc/acpi/alarm BCD alarm encodings

On Thu, 25 Oct 2007 15:04:18 -0700 (PDT)
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> 
> 
> On Thu, 18 Oct 2007, Andrew Morton wrote:
> 
> > On Wed, 17 Oct 2007 23:18:32 -0400
> > Mark Lord <lkml@....ca> wrote:
> > 
> > > >and note the "& 0x3f" which is done in BCD mode. Strange. But we always 
> > > >write zero (which may or may not be correct). So I'd have to add a mask to 
> > > >the interface, and I decided it wasn't worth it until somebody talks about 
> > > >how that thing actually works..
> > > 
> > > Linus, this is your patch from a few weeks ago.
> > > It (still) solves problems for me here.
> > > This should go into 2.6.24.
> > > 
> > > Fix BIN_TO_BCD()/BCD_TO_BIN() handling when setting the real-time alarm clock.
> > 
> > This patch is presently (stuck) in -mm.  I'll move it to my
> > must-be-in-2.6.24-even-if-the-maintainer-fluffs-it queue.
> 
> I noticed that apparently this never happened, and it didn't go into -rc1.
> 
> I'll put it there myself, since I'm the author and Mark tested it, and the 
> old code was definitely totally buggy. The earlier it gets in, the better, 
> in case there are cleanups and/or other issues.
> 

I'll send over my copy.  I don't think it changed.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/