linux-kernel - Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071025164658.8fdc04cc.akpm@linux-foundation.org>
Date:	Thu, 25 Oct 2007 16:46:58 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Zach Brown <zach.brown@...cle.com>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and
 co. [try #5]

On Thu, 25 Oct 2007 16:09:09 -0700
Zach Brown <zach.brown@...cle.com> wrote:

> 
> > + * ERR_CAST - Explicitly cast an error-valued pointer to another pointer type
> > + * @ptr: The pointer to cast.
> > + *
> > + * Explicitly cast an error-valued pointer to another pointer type in such a
> > + * way as to make it clear that's what's going on.
> > + */
> > +static inline void *ERR_CAST(const void *ptr)
> > +{
> > +	return (void *) ptr;
> > +}
> 
> Just to nit, surely you don't need the cast inside the function.  The
> casting happens at the call site between the argument and returned pointer.
> 

It'll warn without the cast.

btw, nit time.  This style:

	return (void *)ptr;

outnumbers this style

	return (void *) ptr;

by 4 to 1.  And I don't find the space attractive, useful or logical,
personally.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/