[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <472027BC.7010400@garzik.org>
Date: Thu, 25 Oct 2007 01:21:00 -0400
From: Jeff Garzik <jeff@...zik.org>
To: Kristen Carlson Accardi <kristen.c.accardi@...el.com>
CC: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
axboe@...nel.dk, akpm@...ux-foundation.org,
Tejun Heo <htejun@...il.com>
Subject: Re: [patch 1/2] Enable link power management for ata drivers
applied as the attached two patches to jgarzik/libata-dev.git#alpm
open issues:
1) need to check ata_dev_set_feature() return value in
ata_dev_set_dipm() and do something useful with it
2) as the name implies, this probably better belongs in ata_link.
3) however, the feature is tightly coupled to the host controller. in
theory PMP -might- do this, but I think its unlikely. as such I was OK
with the present arrangement.
4) there has been some discussion of software-initiated device/link
power management, but I think this should go in, in parallel with those
discussions. ALPM
* is quite self-contained
* gives a noticable power savings
I'm definitely interested in seeing somebody pursue software-initiated
link PM as well...
Jeff
View attachment "patch.1" of type "text/plain" (3467 bytes)
View attachment "patch.2" of type "text/plain" (16518 bytes)
Powered by blists - more mailing lists