linux-kernel - Re: [PATCH 1/?] Unlock when sn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071026.034816.178511694.davem@davemloft.net>
Date:	Fri, 26 Oct 2007 03:48:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	12o3l@...cali.nl
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/?] Unlock when sn_oemdata can't be extended

From: Roel Kluin <12o3l@...cali.nl>
Date: Wed, 24 Oct 2007 12:19:52 +0200

>      Several unlocking issues
>      Signed-off-by: Roel Kluin <12o3l@...cali.nl>

Some of these are wrong, for example:

> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
> index 817169e..b09c499 100644
> --- a/net/bridge/netfilter/ebtables.c
> +++ b/net/bridge/netfilter/ebtables.c
> @@ -282,8 +282,10 @@ find_inlist_lock_noload(struct list_head *head, const char *name, int *error,
>  		return NULL;
>  
>  	list_for_each_entry(e, head, list) {
> -		if (strcmp(e->name, name) == 0)
> +		if (strcmp(e->name, name) == 0) {
> +			mutex_unlock(mutex);
>  			return e;
> +		}
>  	}
>  	*error = -ENOENT;
>  	mutex_unlock(mutex);

Please look at the comment right about this function, it clearly
explains that if the named object is found, the function returns
with the mutex locked.

The rest of the networking cases look OK, please just resubmit
the correct networking cases to netdev@...r.kernel.org.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/