linux-kernel - Re: [lm-sensors] hwmon/f75375s.c: buggy if()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071026111423.GA16559@kos.to>
Date:	Fri, 26 Oct 2007 14:14:23 +0300
From:	Riku Voipio <riku.voipio@....fi>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	"Mark M. Hoffman" <mhoffman@...htlink.com>,
	Adrian Bunk <bunk@...nel.org>, linux-kernel@...r.kernel.org,
	lm-sensors@...sensors.org
Subject: Re: [lm-sensors] hwmon/f75375s.c: buggy if()

On Fri, Oct 26, 2007 at 10:36:47AM +0200, Jean Delvare wrote:
> Patch looks correct, however it doesn't apply on top of Mark's tree. I
> was able to get it to apply by reverting "(f75375s) fix pwm mode
> setting" first, but then the build fails. Presumably the other f75375s
> patches interact badly. Can you please respin this patch on top of
> Mark's tree (i.e. on top the the 4 other f75375s patches you sent since
> the -rc1 merge)? Thanks.

The surrounding code had wandered to another function, so it's suprising
it applied at all. Here's respin.

-- 
"rm -rf" only sounds scary if you don't have backups

View attachment "hwmon-f75375s-fix-buggy-if-properly.patch" of type "text/plain" (2290 bytes)