lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20071026113524.GA10130@Chamillionaire.breakpoint.cc> Date: Fri, 26 Oct 2007 13:35:24 +0200 From: Sebastian Siewior <lkml@...breakpoint.cc> To: Jens Axboe <jens.axboe@...cle.com> Cc: linux-kernel@...r.kernel.org Subject: Re: [BUG] panic after umount (biscted) * Jens Axboe | 2007-10-26 11:32:42 [+0200]: >On Fri, Oct 26 2007, Jens Axboe wrote: >> > >> > I hope this was usefull. Now, I'm going to rebuild my raid now.... >> > >> Thanks a lot, a full report on this issue. Will get this fixed up asap. No problem, thanks for working on that :) > >Does this work? > >diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c >index 61fdaf0..cf47fcb 100644 >--- a/drivers/scsi/scsi_lib.c >+++ b/drivers/scsi/scsi_lib.c >@@ -1115,6 +1115,8 @@ static int scsi_init_io(struct scsi_cmnd *cmd) > * kmapping pages) > */ > cmd->use_sg = req->nr_phys_segments; >+ if (!cmd->use_sg) >+ return 0; > > /* > * If sg table allocation fails, requeue request later. >@@ -1191,7 +1193,7 @@ int scsi_setup_blk_pc_cmnd(struct scsi_device *sdev, struct request *req) > if (req->bio) { > int ret; > >- BUG_ON(!req->nr_phys_segments); >+ BUG_ON(!req->nr_phys_segments && req->bio->bi_size); > > ret = scsi_init_io(cmd); > if (unlikely(ret)) > Nope. I get [1] on manual umount and [2] on system reboot. This is 24-rc1 with this patch on top. [1] http://download.breakpoint.cc/bug/bug_rc1_patch_manual.jpeg 163 KiB [2] http://download.breakpoint.cc/bug/bug_rc1_patch_reboot.jpeg 171 KiB >-- >Jens Axboe Sebastian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists