linux-kernel - Re: [PATCH 1/4] stringbuf: A string buffer implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020710260505y7a6335dbpa201015910744cba@mail.gmail.com>
Date:	Fri, 26 Oct 2007 15:05:31 +0300
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Matthew Wilcox" <matthew@....cx>
Cc:	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org,
	"Matthew Wilcox" <willy@...ux.intel.com>
Subject: Re: [PATCH 1/4] stringbuf: A string buffer implementation

Hi,

On 10/24/07, Matthew Wilcox <matthew@....cx> wrote:
> +static void sb_vprintf(struct stringbuf *sb, const char *format, va_list args)
> +{
> +       char *s;
> +       int size;
> +
> +       if (sb->alloc == -ENOMEM)
> +               return;
> +       if (sb->alloc == 0) {
> +               sb->s = kmalloc(INITIAL_SIZE, GFP_ATOMIC);

How about putting ->gfp_flags to struct stringbuf and initializing
that in sb_init() instead of hard-coding to GFP_ATOMIC here?

Btw, the "sb" abbrevation is already used for "superblock". Perhaps we
could use "str" for these?

                                             Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/