lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Pine.LNX.4.64.0710261422380.29303@blonde.wat.veritas.com> Date: Fri, 26 Oct 2007 14:24:44 +0100 (BST) From: Hugh Dickins <hugh@...itas.com> To: Jan Engelhardt <jengelh@...putergmbh.de> cc: Jiri Kosina <jikos@...os.cz>, Andrew Morton <akpm@...ux-foundation.org>, Sami Farin <safari-kernel@...ari.iki.fi>, Linux kernel Mailing List <linux-kernel@...r.kernel.org>, Jiri Kosina <jkosina@...e.cz>, Arjan van de Ven <arjan@...radead.org> Subject: Re: [PATCH] [RFC] brk randomization: compute RLIMIT_DATA properly (was Re: x86: randomize brk() and RLIMIT_DATA) On Fri, 26 Oct 2007, Jan Engelhardt wrote: > On Oct 26 2007 13:30, Hugh Dickins wrote: > >> @@ -251,7 +251,8 @@ asmlinkage unsigned long sys_brk(unsigned long brk) > >> * not page aligned -Ram Gupta > >> */ > >> rlim = current->signal->rlim[RLIMIT_DATA].rlim_cur; > >> - if (rlim < RLIM_INFINITY && brk - mm->start_data > rlim) > >> + if (rlim < RLIM_INFINITY && (brk - mm->start_brk) + > >> + (mm->end_data - mm->start_data) > rlim) > >> goto out; > >> > >> newbrk = PAGE_ALIGN(brk); > > Parentheses around (brk - mm->start_brk) + (mm->end_data - mm->start_data) > not strictly necessary. Yes, but don't you find they make it easier to understand the expression? Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists