linux-kernel - Re: [PATCH] IA64, PPC, SPARC: minor irq handler cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Oct 2007 09:55:46 -0500
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, akpm@...ux-foundation.org,
	davem@...emloft.net, tony.luck@...el.com,
	linux-ia64@...r.kernel.org, paulus@...ba.org,
	benh@...nel.crashing.org
Subject: Re: [PATCH] IA64, PPC, SPARC: minor irq handler cleanups


On Oct 26, 2007, at 4:49 AM, Jeff Garzik wrote:

> Kumar Gala wrote:
>> On Oct 26, 2007, at 4:40 AM, Jeff Garzik wrote:
>>> ia64/sn/kernel/huberror.c:
>>>     - remove pointless void* cast
>>>     - add KERN_xxx prefix
>>>
>>> ia64/sn/pci/tioce_provider.c: start functions at column zero
>>>
>>> ppc/8xx_io/fec.c: kill prototype, remove extra whitespace
>>>
>>> ppc/platforms/85xx/*
>>>     'irq' argument in irq handler is used purely as a temporary
>>>     variable.  Update the function to reflect this usage, changing
>>>     the first arg's name from 'irq' to 'dummy'
>>>
>>> ppc/platforms/sbc82xx.c: ditto
>>>
>>> sparc/kernel/time.c: mark timer_interrupt() static (from DaveM)
>>>
>>> Signed-off-by: Jeff Garzik <jgarzik@...hat.com>
>>> ---
>>>  arch/ia64/sn/kernel/huberror.c               |    4 ++--
>>>  arch/ia64/sn/pci/tioce_provider.c            |    6 ++++--
>>>  arch/ppc/8xx_io/fec.c                        |    3 +--
>>>  arch/ppc/platforms/85xx/mpc8560_ads.c        |    4 +++-
>>>  arch/ppc/platforms/85xx/mpc85xx_cds_common.c |    4 +++-
>>>  arch/ppc/platforms/85xx/stx_gp3.c            |    4 +++-
>>>  arch/ppc/platforms/85xx/tqm85xx.c            |    4 +++-
>>>  arch/ppc/platforms/sbc82xx.c                 |    4 +++-
>>>  arch/sparc/kernel/time.c                     |    2 +-
>>>  9 files changed, 23 insertions(+), 12 deletions(-)
>> I haven't been following this with detail.  Is the intent that  
>> this would be for 2.6.24 or .25?
>
> These patches are all cleanups and minor fixes I found while  
> iterating through each interrupt handler in the kernel, in pursuit  
> of a related project.
>
> So they can stand by themselves, and can integrate into whatever  
> flow maintainers find most comfortable.
>
> I'm not in any rush, but neither would I like them to sit forever...

Ok. Not to be a pain, but it would be easier if this one patch might  
be easier if it was split down the arch lines so each maintainer can  
deal with it.

I say this especially for the ppc code because the intent in 2.6.25  
is to actually try and remove some of the files you are fixing up for  
their arch/powerpc variants.

- k
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/