lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20071026155058.GC23016@kroah.com> Date: Fri, 26 Oct 2007 08:50:58 -0700 From: Greg KH <greg@...ah.com> To: Amit Shah <amitshah@....net> Cc: linux-kernel@...r.kernel.org Subject: Re: sysfs: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() On Fri, Oct 26, 2007 at 12:44:38PM +0530, Amit Shah wrote: > On 2.6.24-rc1, I get this for all my eth interfaces: > > [ 150.389821] sysfs: duplicate filename 'eth1_rename' can not be created > [ 150.389824] WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() I sent out the patch below for comments, yet no one did :( Can you try it out and let me know if it works for you or not? thanks, greg k-h ------------ From: Greg Kroah-Hartman <gregkh@...e.de> Subject: kobject: check for duplicate names in kobject_rename This should catch any duplicate names before we try to tell sysfs to rename the object. This happens a lot with older versions of udev and the network rename scripts. Cc: David Miller <davem@...emloft.net> Cc: Kay Sievers <kay.sievers@...y.org> Cc: Rafael J. Wysocki <rjw@...k.pl> Cc: Tejun Heo <htejun@...il.com> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de> --- lib/kobject.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) --- a/lib/kobject.c +++ b/lib/kobject.c @@ -308,6 +308,19 @@ int kobject_rename(struct kobject * kobj if (!kobj->parent) return -EINVAL; + /* see if this name is already in use */ + if (kobj->kset) { + struct kobject *temp_kobj; + temp_kobj = kset_find_obj(kobj->kset, new_name); + if (temp_kobj) { + printk(KERN_WARNING "kobject '%s' can not be renamed " + "to '%s' as '%s' is already in existance.\n", + kobject_name(kobj), new_name, new_name); + kobject_put(temp_kobj); + return -EINVAL; + } + } + devpath = kobject_get_path(kobj, GFP_KERNEL); if (!devpath) { error = -ENOMEM; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists