lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <47221164.10200@ru.mvista.com> Date: Fri, 26 Oct 2007 20:10:12 +0400 From: Sergei Shtylyov <sshtylyov@...mvista.com> To: Russell King <rmk@....linux.org.uk> Cc: linux-ide@...r.kernel.org, Bartlomiej Zolnierkiewicz <bzolnier@...il.com>, Jeff Garzik <jgarzik@...ox.com>, Alan Cox <alan@...rguk.ukuu.org.uk>, Linux Kernel List <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org>, Linus Torvalds <torvalds@...ux-foundation.org> Subject: Re: Regression: commit "ide: constify struct ide_port_info" causes breakage Hello. Russell King wrote: > commit 8562043606430185cad26d085d46adcc7ad67fd1 is broken, causing: > CC drivers/ide/pci/cmd64x.o > CC drivers/ide/pci/hpt366.o > drivers/ide/pci/hpt366.c:1428: error: hpt366_chipsets causes a section type conflict > and therefore should be reverted. > > The problem arises because hpt366 has other data marked with __devinitdata, > so the compiler tries to define the initdata section with read-write > attributes at one point, and read-only attributes when encountering the > const-but-devinitdata declaration: > > static struct hpt_info hpt36x __devinitdata = { > static struct hpt_info hpt370 __devinitdata = { > static struct hpt_info hpt370a __devinitdata = { > ... > static const struct ide_port_info hpt366_chipsets[] __devinitdata = { > If we want ide_port_info to be read-only initdata, then we need > __devroinitdata and __roinitdata tags. We can just convert cariables declared as 'struct hpt_info' to const too -- they are read-only templates. MBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists