linux-kernel - Re: Regression: commit "ide: constify struct ide_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Oct 2007 20:38:15 +0400
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Russell King <rmk@....linux.org.uk>, linux-ide@...r.kernel.org,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	Jeff Garzik <jgarzik@...ox.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linux Kernel List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: Regression: commit "ide: constify struct ide_port_info" causes
 breakage

Hello.

Linus Torvalds wrote:

>>   We can just convert cariables declared as 'struct hpt_info' to const too -- 
>>they are read-only templates.

> Generally "__devinitdata" is better than "const", since it means that the 
> data may be thrown away.

    Agreed.

> So if you drop one over the other,

    No, just add 'const' to already __devinitdata data to make gcc happy again.

> it's generally the "const" that should be dropped ;/

    Well, this may break when/if we need to add __devinitdata that is actually 
r/w -- not likely with this driver but still...

> 		Linus

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/