lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <47221D6D.3000807@zytor.com> Date: Fri, 26 Oct 2007 10:01:33 -0700 From: "H. Peter Anvin" <hpa@...or.com> To: Ingo Molnar <mingo@...e.hu> CC: Simon Holm Thøgersen <odie@...aau.dk>, linux-kernel@...r.kernel.org Subject: Re: [patch] raid6: generate raid6tables.c with proper style Ingo Molnar wrote: > * Simon Holm Thøgersen <odie@...aau.dk> wrote: > >> fre, 26 10 2007 kl. 10:17 +0200, skrev Ingo Molnar: >>> Subject: raid6: generate raid6tables.c with proper style >>> From: Ingo Molnar <mingo@...e.hu> >> [snip] >> >>> Index: linux/drivers/md/mktables.c >>> =================================================================== >>> --- linux.orig/drivers/md/mktables.c >>> +++ linux/drivers/md/mktables.c >>> @@ -69,7 +69,9 @@ int main(int argc, char *argv[]) >>> for ( j = 0 ; j < 256 ; j += 8 ) { >>> printf("\t\t"); >>> for ( k = 0 ; k < 8 ; k++ ) { >>> - printf("0x%02x, ", gfmul(i,j+k)); >>> + if (k) >>> + printf(" "); >>> + printf("0x%02x,", gfmul(i,j+k)); >> What happened with the coding style here? > > i adopted to the existing (broken) one. Yes, mktables.c could need a > good cleanup too. > More so than the output, IMNSHO. I'll take care of it. -hpa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists