lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1193422064.2190.6.camel@lov.site> Date: Fri, 26 Oct 2007 20:07:44 +0200 From: Kay Sievers <kay.sievers@...y.org> To: Larry Finger <Larry.Finger@...inger.net> Cc: Greg Kroah-Hartman <gregkh@...e.de>, LKML <linux-kernel@...r.kernel.org> Subject: Re: linux-2.6.23-git3: Many sysfs-related warnings in dmesg On Fri, 2007-10-26 at 12:05 -0500, Larry Finger wrote: > On my openSUSE 10.3 x86_64 system running v2.6.24-rc1-281-g22d2aa1, > I get the sysfs rename messages. Care to try this? Seems like a silly bug in the core if SYSFS_DEPRECATED=y. That's why we didn't catch this earlier, sorry. Thanks a lot for the help, Kay From: Kay Sievers <kay.sievers@...y.org> Subject: Driver Core: fix bug in device_rename() for SYSFS_DEPRECATED=y Signed-off-by: Kay Sievers <kay.sievers@...y.org> --- diff --git a/drivers/base/core.c b/drivers/base/core.c index c134341..3f4d6aa 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1228,18 +1228,18 @@ int device_rename(struct device *dev, char *new_name) sysfs_remove_link(&dev->parent->kobj, old_class_name); } } -#endif - +#else if (dev->class) { sysfs_remove_link(&dev->class->subsys.kobj, old_device_name); error = sysfs_create_link(&dev->class->subsys.kobj, &dev->kobj, dev->bus_id); if (error) { - /* Uh... how to unravel this if restoring can fail? */ dev_err(dev, "%s: sysfs_create_symlink failed (%d)\n", __FUNCTION__, error); } } +#endif + out: put_device(dev); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists