lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <200710262019.12094.arnd@arndb.de> Date: Fri, 26 Oct 2007 20:19:10 +0200 From: Arnd Bergmann <arnd@...db.de> To: linuxppc-dev@...abs.org Cc: Olof Johansson <olof@...om.net>, paulus@...ba.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] [POWERPC] Fix CONFIG_SMP=n build break On Friday 26 October 2007, Olof Johansson wrote: > Fix two build errors on powerpc allyesconfig + CONFIG_SMP=n: > > arch/powerpc/platforms/built-in.o: In function `cpu_affinity_set': > arch/powerpc/platforms/cell/spu_priv1_mmio.c:78: undefined reference to > `.iic_get_target_id' arch/powerpc/platforms/built-in.o: In function > `iic_init_IRQ': > arch/powerpc/platforms/cell/interrupt.c:397: undefined reference to > `.iic_setup_cpu' Thanks for reporting this. > --- a/arch/powerpc/platforms/cell/spu_priv1_mmio.c > +++ b/arch/powerpc/platforms/cell/spu_priv1_mmio.c > @@ -75,9 +75,11 @@ static u64 int_stat_get(struct spu *spu, int class) > > static void cpu_affinity_set(struct spu *spu, int cpu) > { > +#ifdef CONFIG_SMP > u64 target = iic_get_target_id(cpu); > u64 route = target << 48 | target << 32 | target << 16; > out_be64(&spu->priv1->int_route_RW, route); > +#endif > } I think here it would be better to move iic_get_target_id out of CONFIG_SMP as well. We might want to kexec from an SMP kernel into a UP kernel, and in that case, cpu_affinity_set() should better reset the routing to CPU 0. Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists