linux-kernel - Re: [PATCH] Remove #warnings for longstanding conditions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47214BD5.4020106@garzik.org>
Date:	Thu, 25 Oct 2007 22:07:17 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Matthew Wilcox <matthew@....cx>
CC:	LKML <linux-kernel@...r.kernel.org>, linux-scsi@...r.kernel.org,
	akpm@...ux-foundation.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] Remove #warnings for longstanding conditions.

Matthew Wilcox wrote:

>> drivers/scsi/advansys.c:71:2: warning: #warning this driver is still
>> not properly converted to the DMA API

> I'll be removing this #warning from advansys when I get rid of the
> last bus_to_virt.  Which I've already done ... it's just that the
> resulting driver works on i386, but crashes parisc, so there's clearly a
> bug.  I haven't had time to track it down yet.  So NACK this patch.

Well, two main questions...

Is this warning of value to anybody but you?
Is this information worth printing out on everyone else's kernel build?

If yes, great!  But it sounds like this warning is analagous to

   #warning willy's TODO list: get milk, buy groceries, read email, ...

which doesn't add much value to others' kernel builds :)

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/