lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <47227015.6060708@oracle.com> Date: Fri, 26 Oct 2007 15:54:13 -0700 From: Zach Brown <zach.brown@...cle.com> To: Linus Torvalds <torvalds@...ux-foundation.org> CC: Karl Schendel <kschendel@...allegro.com>, Benjamin LaHaise <bcrl@...ck.org>, Andrew Morton <akpm@...ux-foundation.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Nick Piggin <nickpiggin@...oo.com.au>, Leonid Ananiev <leonid.i.ananiev@...ux.intel.com>, Chris Mason <chris.mason@...cle.com> Subject: Re: [PATCH] Fix bad data from non-direct-io read after direct-io write Linus Torvalds wrote: > > On Fri, 26 Oct 2007, Zach Brown wrote: >> I think that test should be changed to > > How about not testing at all? Which was what the old code did. > > Just do the invalidate unconditionally for any writes, and screw the end > result of the invalidate, since we cannot afford to overwrite the previous > return value anyway in any realistic scenario? I'm reasonably comfortable with that, sure. This second invalidation only catches reads which userspace raced with the write, and that's already racy by definition. I can throw together a patch if you haven't already committed one by the time you read this ;). - z - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists