linux-kernel - Re: [PATCH 1/2] fix typo in SubmittingPatches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071026205009.24ec2d83.randy.dunlap@oracle.com>
Date:	Fri, 26 Oct 2007 20:50:09 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Keiichi KII <k-keiichi@...jp.nec.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	gregkh@...e.de, Andy Whitcroft <apw@...dowen.org>
Subject: Re: [PATCH 1/2] fix typo in SubmittingPatches

On Fri, 26 Oct 2007 15:51:44 +0900 Keiichi KII wrote:

> From: Keiichi Kii <k-keiichi@...jp.nec.com>
> 
> Fix typo.
> 
> Signed-off-by: Keiichi Kii <k-keiichi@...jp.nec.com>
> Cc: Andy Whitcroft <apw@...dowen.org>
> ---
> Index: trunk/Documentation/SubmittingPatches
> ===================================================================
> --- trunk.orig/Documentation/SubmittingPatches
> +++ trunk/Documentation/SubmittingPatches
> @@ -464,7 +464,7 @@ section Linus Computer Science 101.
>  Nuff said.  If your code deviates too much from this, it is likely
>  to be rejected without further review, and without comment.
>  
> -Once significant exception is when moving code from one file to
> +One significant exception is when moving code from one file to
>  another in this case you should not modify the moved code at all in
>  the same patch which moves it.  This clearly delineates the act of
>  moving the code and your changes.  This greatly aids review of the

That first sentence is still broken.  It should be more like this,
with either a ":" or ";" or " -- " between clauses:

One significant exception is when moving code from one file to
another -- in this case you should not modify the moved code at all in
the same patch which moves it.


---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/