linux-kernel - Re: [PATCH] DMAENGINE: too many kref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071027064029.GM8181@ftp.linux.org.uk>
Date:	Sat, 27 Oct 2007 07:40:29 +0100
From:	Al Viro <viro@....linux.org.uk>
To:	Shannon Nelson <shannon.nelson@...el.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	greg@...ah.com, hskinnemoen@...el.com, dan.j.williams@...el.com
Subject: Re: [PATCH] DMAENGINE: too many kref_put calls

On Fri, Oct 26, 2007 at 04:56:48PM -0700, Shannon Nelson wrote:

>  static void dma_dev_release(struct device *dev)
>  {
> -	struct dma_chan *chan = to_dma_chan(dev);
> -	kref_put(&chan->device->refcount, dma_async_device_cleanup);
> +	return;
>  }

Practically guaranteed to be broken.  Empty ->release() is almost certain
to mean that you can get operations on already freed object.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/