linux-kernel - Re: [PATCH] backlight dimmer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071028143445.4617efd8@laptopd505.fenrus.org>
Date:	Sun, 28 Oct 2007 14:34:45 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	"lists@...onello.org" <lists@...onello.org>
Cc:	Samuel Tardieu <sam@...1149.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] backlight dimmer

On Sun, 28 Oct 2007 22:30:55 +0100
"lists@...onello.org" <lists@...onello.org> wrote:

> Ok,
>   now checkpatch.pl only complains about a missing signed-off-by.
> Is this ok for review?


hi,

when going over your patch.. is there a reason you introduce yet
another timeout infrastructure? Is there something wrong with the
existing ones that maybe should be fixed instead?
Either way.. please put justification for such new mechanism in the
patch changelog....

Greetings,
   Arjan van de Ven

-- 
If you want to reach me at my work email, use arjan@...ux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/