linux-kernel - Re: [PATCH] sysctl: fix token-ring procname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m1wst6q2pe.fsf@ebiederm.dsl.xmission.com>
Date:	Sun, 28 Oct 2007 16:44:29 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	webmaster@...gonslave.de, akpm <akpm@...ux-foundation.org>,
	Daniel Exner <dex@...gonslave.de>,
	linux-kernel@...r.kernel.org, Jeff Garzik <jeff@...zik.org>,
	Michal Januszewski <spock@...too.org>
Subject: Re: [PATCH] sysctl: fix token-ring procname

Randy Dunlap <randy.dunlap@...cle.com> writes:

> From: Randy Dunlap <randy.dunlap@...cle.com>
> cc: Eric W. Biederman <ebiederm@...ssion.com>
>
> Correct the token-ring sysctl procname.
>
> Reported by: Daniel Exner <dex@...gonslave.de>:
>
> Ah, and token ring tells me something like
> "/net/token-ring ,3.14 sysctl failed check procname does not match binary path 
> procname"
> But kernel boots otherwise and I got no chance to test tr itself is working.

Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>

"token-ring" is the historical name we have used in /proc/sys despite it
being abbreviated tr in the kernel.  So this fix is definitely
correct.

Sorry about that.  Given this bug and the atalk bug it looks like
I failed to QA the number to name mapping properly under net/.
I just looked at those entries again and I don't see any other
entries under net/ that have problems.

Hopefully this is the last of my silly bugs in this table.

Eric



> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  kernel/sysctl_check.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.24-rc1.orig/kernel/sysctl_check.c
> +++ linux-2.6.24-rc1/kernel/sysctl_check.c
> @@ -738,7 +738,7 @@ static struct trans_ctl_table trans_net_
>  	{ NET_ROSE,		"rose",		trans_net_rose_table },
>  	{ NET_IPV6,		"ipv6",		trans_net_ipv6_table },
>  	{ NET_X25,		"x25",		trans_net_x25_table },
> -	{ NET_TR,		"tr",		trans_net_tr_table },
> +	{ NET_TR,		"token-ring",	trans_net_tr_table },
>  	{ NET_DECNET,		"decnet",	trans_net_decnet_table },
>  	/*  NET_ECONET not used */
>  	{ NET_SCTP,		"sctp",		trans_net_sctp_table },
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/