linux-kernel - Re: [2.6 patch] scsi/seagate.c: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071028155354.GJ27248@parisc-linux.org>
Date:	Sun, 28 Oct 2007 09:53:54 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	James.Bottomley@...elEye.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] scsi/seagate.c: remove dead code

On Sun, Oct 28, 2007 at 04:51:42PM +0100, Adrian Bunk wrote:
> This patch removes obviously dead code.
>  				case LINKED_WRONG:
>  					WRITE_DATA (ABORT);
>  					linked_connected = 0;
>  					reselect = CAN_RECONNECT;
>  					goto connect_loop;
> -					DPRINTK (PHASE_MSGOUT | DEBUG_LINKED, "scsi%d : sent ABORT message to cancel incorrect I_T_L nexus.\n", hostno);
>  #endif					/* LINKED */
> -					DPRINTK (DEBUG_LINKED, "correct\n");
>  				default:

Surely the 'goto' should just be moved two lines down?

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/