linux-kernel - Re: vm_ops.page_mkwrite() fails with vmalloc on 2.6.23

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1193652717.27652.45.camel@twins>
Date:	Mon, 29 Oct 2007 11:11:57 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Jaya Kumar <jayakumar.lkml@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, stefani@...bold.net,
	linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>,
	linux-mm@...ck.org, Nick Piggin <nickpiggin@...oo.com.au>
Subject: Re: vm_ops.page_mkwrite() fails with vmalloc on 2.6.23

On Mon, 2007-10-29 at 01:17 -0700, Jaya Kumar wrote:
> On 10/29/07, Andrew Morton <akpm@...ux-foundation.org> wrote:
> > On Mon, 22 Oct 2007 16:40:57 +0200 Stefani Seibold <stefani@...bold.net> wrote:
> > >
> > > The problem original occurs with the fb_defio driver (driver/video/fb_defio.c).
> > > This driver use the vm_ops.page_mkwrite() handler for tracking the modified pages,
> > > which will be in an extra thread handled, to perform the IO and clean and
> > > write protect all pages with page_clean().
> > >
> 
> Hi,
> 
> An aside, I just tested that deferred IO works fine on 2.6.22.10/pxa255.
> 
> I understood from the thread that PeterZ is looking into page_mkclean
> changes which I guess went into 2.6.23. I'm also happy to help in any
> way if the way we're doing fb_defio needs to change.

Yeah, its the truncate race stuff introduced by Nick in
  d0217ac04ca6591841e5665f518e38064f4e65bd

I'm a bit at a loss on how to go around fixing this. One ugly idea I had
was to check page->mapping before going into page_mkwrite() and when
that is null, don't bother with the truncate check.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/