lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 29 Oct 2007 13:00:26 +0000
From:	David Howells <dhowells@...hat.com>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] fs/afs/vlocation.c: fix off-by-one

Adrian Bunk <bunk@...nel.org> wrote:

> This patch fixes an off-by-one error spotted by the Coverity checker.

NAK.

Why do you assume it's a NUL-terminated string?  It's not.  It's a fixed
length character array that gets padded out with NULs.

Look 9 lines further down in the file from the change you made.  You'll notice
it is using memcmp() not strcmp().

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ