lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20071029131540.13932677.sfr@canb.auug.org.au>
Date:	Mon, 29 Oct 2007 13:15:40 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Christoph Lameter <clameter@....com>
Cc:	linux-mm@...ck.org, LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] slub: nr_slabs is an atomic_long_t

so shouldn't be passed to atomic_read.

mm/slub.c: In function 'slab_mem_offline_callback':
mm/slub.c:2737: warning: passing argument 1 of 'atomic_read' from incompatible pointer type
mm/slub.c:2737: warning: passing argument 1 of 'atomic_read' from incompatible pointer type
mm/slub.c:2737: warning: passing argument 1 of 'atomic_read' from incompatible pointer type

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 mm/slub.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Seen on PowerPC allyesconfig build.
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

diff --git a/mm/slub.c b/mm/slub.c
index aac1dd3..bcdb2c8 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2734,7 +2734,7 @@ static void slab_mem_offline_callback(void *arg)
 			 * and offline_pages() function shoudn't call this
 			 * callback. So, we must fail.
 			 */
-			BUG_ON(atomic_read(&n->nr_slabs));
+			BUG_ON(atomic_long_read(&n->nr_slabs));
 
 			s->node[offline_node] = NULL;
 			kmem_cache_free(kmalloc_caches, n);
-- 
1.5.3.4

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists