linux-kernel - Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4725F2DF.1060500@garzik.org>
Date:	Mon, 29 Oct 2007 10:49:03 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	Jiri Kosina <jikos@...os.cz>,
	Dirk Hohndel <hohndel@...ux.intel.com>,
	linux-input@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device

Dmitry Torokhov wrote:
> On 10/29/07, Jiri Kosina <jikos@...os.cz> wrote:
>> On Mon, 29 Oct 2007, Dirk Hohndel wrote:
>>
>>> [INPUT] hidinput_connect incorrectly ignored return value from
>>> input_register_device
>>> Signed-off-by: Dirk Hohndel <hohndel@...ux.intel.com>
>> Will apply
> 
> Please don't - the fix is completely broken for multi-input devices -
> if 2nd device fails to register we bail out of hidinput_connect and
> thus never set HID_CLAIMED_INPUT bit. So when we disconnect device we
> never call hidinput_disconnect and who knows what will happen after
> that.
> 
> hidinput_connect() should properly unwind already registered devices
> after failure.

Then the existing code to handle hidinput and input_dev allocation 
failure probably also wants fixing...  Dirk's patch was largely 
following the same logic.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/