linux-kernel - Re: [Git Patch] arch/um/os-Linux/: varied improvements and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071029165529.GA6055@c2.user-mode-linux.org>
Date:	Mon, 29 Oct 2007 12:55:29 -0400
From:	Jeff Dike <jdike@...toit.com>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	user-mode-linux-devel@...ts.sourceforge.net,
	Andrew Morton <akpm@...l.org>
Subject: Re: [Git Patch] arch/um/os-Linux/: varied improvements and fixes

On Sun, Oct 28, 2007 at 03:38:43PM +0800, WANG Cong wrote:
> This patch contains varied fixes and improvements for some files under
> arch/um/os-Linux/, such as a typo fix in a perror message, a missing
> argument fix for a printf, some constifying for pointers and so on.

Generally looks good, thanks.


>  		printf("failed to install handler for signal %d - errno = %d\n",
> -		       errno);
> +		       sig, errno);

Nice spotting - I wonder why gcc didn't complain about this.

> -	sigprocmask(on ? SIG_UNBLOCK : SIG_BLOCK, &sigset, &old);
> +	if (sigprocmask(on ? SIG_UNBLOCK : SIG_BLOCK, &sigset, &old) < 0)
> +		return -1;

In cases like this, I return -errno, not -1.  I'll fix this up.

				Jeff

-- 
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/