lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Pine.LNX.4.64.0710282031060.28860@schroedinger.engr.sgi.com> Date: Sun, 28 Oct 2007 20:34:14 -0700 (PDT) From: Christoph Lameter <clameter@....com> To: Pekka J Enberg <penberg@...helsinki.fi> cc: Matthew Wilcox <matthew@....cx>, akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org Subject: Re: [patch 08/10] SLUB: Optional fast path using cmpxchg_local On Sun, 28 Oct 2007, Pekka J Enberg wrote: > - local_irq_restore(flags); > + object = do_slab_alloc(s, c, gfpflags, node, addr); > + if (unlikely(!object)) > + goto out; Undoing the optimization that one of the earlier patches added. The #ifdef version is for me at least easier to read. The code there is a special unit that has to deal with the most performance critical piece of the slab allocator. And the #ifdef there clarifies that any changes have to be done to both branches. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists