linux-kernel - Re: [PATCH 2/2] netdrvr/ibmlana: move away from legacy MCA API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4726376E.3080608@garzik.org>
Date:	Mon, 29 Oct 2007 15:41:34 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Jan Engelhardt <jengelh@...putergmbh.de>
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 2/2] netdrvr/ibmlana: move away from legacy MCA API

Jan Engelhardt wrote:
> On Oct 29 2007 15:33, Jeff Garzik wrote:
>> +#if 0 /* info available elsewhere, but this is kept for reference */
> 
> It is available in the git history, yes, is it still needed for reference?

it's there to see if anyone complains at its removal :)


>> +static short ibmlana_adapter_ids[] __initdata = {
>> +	IBM_LANA_ID,
>> +	0x0000
>> +};
>> +
>> +static char *ibmlana_adapter_names[] __initdata = {
>> +	"IBM LAN Adapter/A",
>> +	NULL
>> +};
> 
> Can this be const?

Not with the initdata marker, no.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/