linux-kernel - Re: [RFC] Create instrumentation directory (git repository)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Oct 2007 19:35:15 -0400
From:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Randy Dunlap <rdunlap@...otime.net>, hch@...radead.org,
	linux-kernel@...r.kernel.org, Sam Ravnborg <sam@...nborg.org>,
	Jens Axboe <jens.axboe@...cle.com>,
	Prasanna S Panchamukhi <prasanna@...ibm.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <pzijlstr@...hat.com>,
	Philippe Elie <phil.el@...adoo.fr>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"William L. Irwin" <wli@...omorphy.com>,
	Arjan van de Ven <arjan@...radead.org>,
	Christoph Lameter <christoph@...eter.com>,
	Valdis.Kletnieks@...edu
Subject: Re: [RFC] Create instrumentation directory (git repository)

* Jeff Garzik (jeff@...zik.org) wrote:
> Mathieu Desnoyers wrote:
> >* Jeff Garzik (jeff@...zik.org) wrote:
> >>Randy Dunlap wrote:
> >>>On Mon, 29 Oct 2007 17:51:38 -0400 Mathieu Desnoyers wrote:
> >>>
> >>>>Hi,
> >>>>
> >>>>Since we already have the Instrumentation menu in
> >>>>kernel/Kconfig.instrumentation and instrumentation code all over the
> >>>>kernel tree:
> >>>>
> >>>>arch/*/oprofile/*.c
> >>>>kernel/kprobes.c
> >>>>arch/*/kernel/kprobes.c
> >>>>kernel/marker.c
> >>>>kernel/profile.c
> >>>>kernel/lockdep.c
> >>>>vm/vmstat.c
> >>>>block/blktrace.c
> >>>>drivers/base/power/trace.c
> >>>>
> >>>>We could move them to
> >>>>
> >>>>instrumentation/
> >>>>arch/*/instrumentation/
> >>>>
> >>>>Therefore, we could also move the kprobes and marker samples under
> >>>>
> >>>>instrumentation/samples/
> >>>>
> >>>>Here is a link to a git repository containing the changes, based on
> >>>>2.6.24-rc1:
> >>>>
> >>>>git://ltt.polymtl.ca/linux-2.6-instrumentation.git 
> >>>>instrumentation-for-linus
> >>>>(the interesting range is : v2.6.24-rc1..instrumentation-for-linus)
> >>>>
> >>>>Through the gitweb interface:
> >>>>http://ltt.polymtl.ca/cgi-bin/gitweb.cgi?p=linux-2.6-instrumentation.git
> >>>>
> >>>>Feedback is appreciated. Sorry for the huge CC list, but the change
> >>>>involves many maintainers.
> >>>Two more added.  Jeff Garzik and Christoph H. sometimes have some 
> >>>comments
> >>>about this.
> >>>
> >>>It would be helpful if we could get comments on this in the next day
> >>>or two [instead of in 1-2 weeks].
> >>"instrumentation" is long, and painful to the fingers :)
> >>
> >
> >Quoting my post from last week:
> >
> >>My main concern is that 15 characters long directory name might be
> >>inelegant (however, it only beats Documentation by 2).
> >
> >And quoting the answer from Valdis.Kletnieks@...edu :
> >How so?  i n s esc.  4 keystrokes (and still 2 more than D<ESC> ;)
> >
> >
> >
> >Better suggestions are wery welcome. However, in modern shells,
> >auto-completion is cheap nowadays.
> 
> That is no excuse for extreme verbosity.  It makes ls(1) displays ugly, 
> it makes diffstat ugly, it causes long pathnames to be truncated in 
> various display-oriented programs.
> 
> Pick a shorter word like probes or profile or what... or better yet... 
> just leave most things in their current directories.
> 
> Shuffling files around just to put them into directories with extra-long 
> names is highly undesirable.
> 
> 

I'll keep the probes and profile directory name ideas in mind, thanks.

This patchset does more than moving things around : its purpose is to
gather various kernel files that have similar purpose (instrumentation)
into a single directory so that it becomes easier to work on these
without duplicating the effort.

I see no good reason to have so many different adhoc instrumentation
mechanisms for profiling (sched, vm, oprofile) and tracing (blktrace,
suspend/resume tracing) all over the place. Merging them in a single
directory seems like a good step towards a more generic
instrumentation/profiling/tracing infrastructure.

Back to "profile" and "probes" directory names, they might be short, but
they do not represent the whole markup-profiling-tracing trio,
"profile" lacks the tracing part and "probe" lacks the markup part.

Mathieu

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/