lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 30 Oct 2007 10:00:30 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Paul Jimenez <pj@...ce.org>
cc:	linux-kernel@...r.kernel.org, mingo@...hat.com, hpa@...or.com
Subject: Re: [PATCH] KJ: Make i8259_64 more _32-like

On Tue, 30 Oct 2007, Paul Jimenez wrote:

> 
> Howdy! Here's a simple janitorish patch for you:
> 
> This patch mainly hinges around two includes and their ramifications:
> 
> #include <i8259.h>	which provides cached_{slave,master}_mask
> #include <io_ports.h>	which provides PIC_{MASTER,SLAVE}_{IMR,CMD} 
> 
> Adding these two includes and using those half dozen or so definitions
> removed 140+ lines of diffs between i8259_32.c and i8259_64.c, thus
> making it easier for the real substantitive differences between them to
> show up, and hopefully therefore making it easier to eventually merge
> the two.

Looks good. Can you please resend with a proper Signed-off-by ?

Run your patch through scripts/checkpatch.pl before sending it out :)

    tglx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists