linux-kernel - Re: [RFC] Create instrumentation directory (git repository)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47267F15.9090302@garzik.org>
Date:	Mon, 29 Oct 2007 20:47:17 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
CC:	Randy Dunlap <rdunlap@...otime.net>, hch@...radead.org,
	linux-kernel@...r.kernel.org, Sam Ravnborg <sam@...nborg.org>,
	Jens Axboe <jens.axboe@...cle.com>,
	Prasanna S Panchamukhi <prasanna@...ibm.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <pzijlstr@...hat.com>,
	Philippe Elie <phil.el@...adoo.fr>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"William L. Irwin" <wli@...omorphy.com>,
	Arjan van de Ven <arjan@...radead.org>,
	Christoph Lameter <christoph@...eter.com>,
	Valdis.Kletnieks@...edu
Subject: Re: [RFC] Create instrumentation directory (git repository)

Mathieu Desnoyers wrote:
> I see no good reason to have so many different adhoc instrumentation
> mechanisms for profiling (sched, vm, oprofile) and tracing (blktrace,
> suspend/resume tracing) all over the place. Merging them in a single
> directory seems like a good step towards a more generic
> instrumentation/profiling/tracing infrastructure.

Moving files about in directories should be at the /lowest/ end of the 
priority scale.  It makes diffs unreadable, file histories and diffing 
difficult, and a host of other problems.

Please solve the /real/ problems, and then come back and clean up the 
file structure after that is done.  Massive file renaming to satisfying 
some imagined future everything-is-golden scheme is the /last/ step.  It 
is the last step taken because the previous steps inevitably give you 
guidance that you otherwise would not have had at the start of the task.

When I try to diff between old and new alpha oprofile code, I really 
want to know that the reason why diffing is a pain in the ass is more 
than "it seemed like a good first step."


> Back to "profile" and "probes" directory names, they might be short, but
> they do not represent the whole markup-profiling-tracing trio,
> "profile" lacks the tracing part and "probe" lacks the markup part.

You can always add more letters (and words) to even reach the desired 
level of specificity.  That does nothing to help readability though.

Anyway, it should be clear from existing precedent -- existing pathnames 
-- that "instrumentation" is too long, and really IMO too vague anyway.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/