[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20071030095548.GB22413@infradead.org>
Date: Tue, 30 Oct 2007 09:55:48 +0000
From: Christoph Hellwig <hch@...radead.org>
To: Daniel Phillips <phillips@...gle.com>
Cc: Christoph Hellwig <hch@...radead.org>,
Erez Zadok <ezk@...sunysb.edu>, viro@....linux.org.uk,
akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c
On Sun, Oct 28, 2007 at 07:57:47PM -0700, Daniel Phillips wrote:
> On 10/28/07, Christoph Hellwig <hch@...radead.org> wrote:
> > While you're at it, it's probably worth splitting this out into
> > a small helper function.
>
> Why? Is the same pattern called from more than one place?
Becauase it's a lot more readable. ioctl subcommands are invidividual
functionality, and separating them out into small self-contained functions
makes the code a lot more readable.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists