linux-kernel - Re: [PATCH 0/4] Unexport several headers and cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1193754356.2651.7.camel@shinybook.infradead.org>
Date:	Tue, 30 Oct 2007 10:25:56 -0400
From:	David Woodhouse <dwmw2@...radead.org>
To:	"Kirill A. Shutemov" <k.shutemov@...il.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Mike Frysinger <vapier.adi@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] Unexport several headers and cleanup

On Tue, 2007-10-30 at 15:50 +0200, Kirill A. Shutemov wrote:
> It's bad idea. Taken from directfb:
> 
> #if HAVE_ASM_PAGE_H
> #include <asm/page.h>
> #else
> #define PAGE_SIZE   sysconf( _SC_PAGESIZE )
> #endif
> 
> Other application can use something like this. I think we should drop
> empty headers.

Well, it ought to be using sysconf unconditionally, but I take your
point. I'm happy enough then -- and since it doesn't change the kernel
build it could perhaps even be considered for 2.6.24.

Here you are... make sure you use them in the correct order:
Reviewed-By: David Woodhouse <dwmw2@...radead.org>
Reviewed-By: David Woodhouse <dwmw2@...radead.org>
Reviewed-By: David Woodhouse <dwmw2@...radead.org>
Reviewed-By: David Woodhouse <dwmw2@...radead.org>

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/