linux-kernel - Re: [alsa-devel] sysfs: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 30 Oct 2007 14:12:11 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:	Greg KH <greg@...ah.com>, alsa-devel@...a-project.org,
	Amit Shah <amitshah@....net>, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] sysfs: WARNING: at	fs/sysfs/dir.c:424	sysfs_add_one() - with	ALSA

At Mon, 29 Oct 2007 08:30:50 +0100,
I wrote:
> 
> At Fri, 26 Oct 2007 22:45:38 +0530,
> Kamalesh Babulal wrote:
> > 
> > Takashi Iwai wrote:
> > > At Fri, 26 Oct 2007 08:52:02 -0700,
> > > Greg KH wrote:
> > >> On Fri, Oct 26, 2007 at 02:47:22PM +0530, Kamalesh Babulal wrote:
> > >>> I get similar warning, while loading the alsa driver
> > >> This is a different problem, not a rename issue like the network one
> > >> was.
> > >>
> > >>> [  191.933548] Advanced Linux Sound Architecture Driver Version 1.0.15
> > >>> (Tue Oct 23 06:09:18 2007 UTC).
> > >>> [  191.996323] ALSA sound/core/seq/oss/seq_oss.c:232: can't register
> > >>> device seq
> > >>> [  192.046004] sysfs: duplicate filename 'audio' can not be created
> > >>> [  192.086048] WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
> > >> This is an error in the alsa core, perhaps the alsa developers can help
> > >> figure out why they are registering the same file twice?
> > > 
> > > ALSA core shouldn't do so.  Maybe a built-in OSS driver conflict with
> > > ALSA?  We'd need to check .config, then.
> > > 
> > > 
> > > Takashi
> > > -
> > Hi Takashi,
> > 
> > Attaching the .config file,
> 
> You're using allyesconfig, and it's a missing runtime configuration to
> avoid the duplication.  Some ALSA and OSS drivers can be loaded
> without real hardwares.  With allyesconfig, ALSA and OSS drivers may
> be registered to the same device unless explicitly set up.

Meanwhile, it's not sexy to have such warnings from sysfs core, not
from the caller side.

The (untested) patch below may fix the problem.  Now the standard
register_sound_*() is used for old OSS code.  Please give it a try.


Takashi


[PATCH] Use register_sound_*() in OSS core code

Use the standard register_sound_*() functions instead of calling
device_create() directly in the old OSS core code.

Signed-off-by: Takashi Iwai <tiwai@...e.de>

---

diff --git a/sound/oss/soundcard.c b/sound/oss/soundcard.c
index a9c23b2..2c20e70 100644
--- a/sound/oss/soundcard.c
+++ b/sound/oss/soundcard.c
@@ -523,15 +523,11 @@ bad:
  */
 static const struct {
 	unsigned short minor;
-	char *name;
-	umode_t mode;
 	int *num;
 } dev_list[] = { /* list of minor devices */
 /* seems to be some confusion here -- this device is not in the device list */
-	{SND_DEV_DSP16,     "dspW",	 S_IWUGO | S_IRUSR | S_IRGRP,
-	 &num_audiodevs},
-	{SND_DEV_AUDIO,     "audio",	 S_IWUGO | S_IRUSR | S_IRGRP,
-	 &num_audiodevs},
+	{SND_DEV_DSP16, &num_audiodevs},
+	{SND_DEV_AUDIO, &num_audiodevs},
 };
 
 static int dmabuf;
@@ -560,17 +556,11 @@ static int __init oss_init(void)
 	sound_dmap_flag = (dmabuf > 0 ? 1 : 0);
 
 	for (i = 0; i < ARRAY_SIZE(dev_list); i++) {
-		device_create(sound_class, NULL,
-			      MKDEV(SOUND_MAJOR, dev_list[i].minor),
-			      "%s", dev_list[i].name);
-
 		if (!dev_list[i].num)
 			continue;
-
-		for (j = 1; j < *dev_list[i].num; j++)
-			device_create(sound_class, NULL,
-				      MKDEV(SOUND_MAJOR, dev_list[i].minor + (j*0x10)),
-				      "%s%d", dev_list[i].name, j);
+		for (j = 0; j < *dev_list[i].num; j++)
+			register_sound_special(&oss_sound_fops,
+					       dev_list[i].minor + (j * 0x10));
 	}
 
 	if (sound_nblocks >= 1024)
@@ -584,11 +574,10 @@ static void __exit oss_cleanup(void)
 	int i, j;
 
 	for (i = 0; i < ARRAY_SIZE(dev_list); i++) {
-		device_destroy(sound_class, MKDEV(SOUND_MAJOR, dev_list[i].minor));
 		if (!dev_list[i].num)
 			continue;
-		for (j = 1; j < *dev_list[i].num; j++)
-			device_destroy(sound_class, MKDEV(SOUND_MAJOR, dev_list[i].minor + (j*0x10)));
+		for (j = 0; j < *dev_list[i].num; j++)
+			unregister_sound_special(dev_list[i].minor + (j * 0x10));
 	}
 	
 	unregister_sound_special(1);
diff --git a/sound/sound_core.c b/sound/sound_core.c
index 46daca1..3a22848 100644
--- a/sound/sound_core.c
+++ b/sound/sound_core.c
@@ -259,6 +259,9 @@ int register_sound_special_device(const struct file_operations *fops, int unit,
 	    case 4:
 		name = "audio";
 		break;
+	    case 5:
+		name = "dspW";
+		break;
 	    case 8:
 		name = "sequencer2";
 		if (unit >= SOUND_STEP)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/