[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20071030153704.GB8285@linux.vnet.ibm.com>
Date: Tue, 30 Oct 2007 08:37:04 -0700
From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To: Patrick McHardy <kaber@...sh.net>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
rusty@....ibm.com, zhaojingmin@...rs.sourceforge.net,
davem@...emloft.net
Subject: Re: [PATCH] nf_nat_h323.c unneeded rcu_dereference() calls
On Tue, Oct 30, 2007 at 03:06:20PM +0100, Patrick McHardy wrote:
> Paul E. McKenney wrote:
> >Hello!
> >
> >While reviewing rcu_dereference() uses, I came across a number of cases
> >where I couldn't see how the rcu_dereference() helped. One class of
> >cases is where the variable is never subsequently dereferenced, so that
> >patches like the following one would be appropriate.
> >
> >So, what am I missing here?
>
> Nothing, it was mainly intended as documentation that the hooks are
> protected by RCU. I agree that its probably more confusing this way
> since we're not even in a rcu_read_lock protected section.
>
> I've queued a patch to remove them all.
Thank you!!!
Thanx, Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists